Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow BooleanSqlToggle to share a single <connnectionStrings> named connection #96

Closed
jason-roberts opened this issue Jul 3, 2015 · 3 comments
Milestone

Comments

@jason-roberts
Copy link
Owner

See #88 for more background

<connectionStrings>
    <add name="primary" connectionString="connection-string" />
</connectionStrings>

<appSettings>
    <add key="FeatureToggle.MyFeatureToggle.ConnectionStringName" value="primary" />
</appSettings>
@craig-wagner
Copy link
Contributor

Just submitted a pull request (#97) for this feature (with unit tests). This is the first time I've tried contributing. Followed the instructions on https://guides.github.com/activities/forking. Let me know if anything needs improvement.

jason-roberts added a commit that referenced this issue Jul 8, 2015
@jason-roberts
Copy link
Owner Author

@craig-wagner - do you want to take a quick look at this d6a1564 just to check it's still operating as you expected? If all is well we can get v3.2 released this week :)

@craig-wagner
Copy link
Contributor

@jason-roberts - Looks like it still works as I intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants