V2.10.0 - Docker Compose and Container Upgrades

[jasonacox]

v2.10.0 - Updates

Docker Compose Config Improvements

• Update powerwall.yml to use variables for "user" and "ports" in containers, per Connecting to Inverter from Public Internet #357 and It is possible to only (network) bind influxdb/weather to localhost? #360 noted by @hulkster
• Updated compose.env.sample with explanation of latest supported options
• Updated powerwall.yml to use "unless-stopped" as the default restart policy for containers going forward
• Credit: @mcbirse - ref Update tesla-history with retry handling on errors #366

Upgrade Containers

• This PR will update the pinning to newer versions of Telegraf and pyPowerwall in powerwall.yml: Telegraf (v1.28.2), pyPowerwall (v0.6.2t28)
• setup.sh - Adds PW_STYLE to pypowerwall.env settings to support newer Grafana versions.
• upgrade.sh - Some cleanup and handling for new PW_STYLE for existing installations.

Related:

• Update tesla-history with retry handling on errors #366
• Update Versions of Grafana and Telegraf #373
• Using more recent versions of Grafana #371
• pypowerwall background color #363
• Docker Desktop Upgrade issue with Telegraf #368

[mcbirse]

Hi Jason,

I have added commits with the proposed changes for powerwall.yml (similar to #366) which include:

• Update powerwall.yml to use variables for "user" and "ports" in containers
• Update compose.env.sample with explanation of latest supported options
• Update upgrade.sh script to replace GRAFANAUSER with PWD_USER in existing compose.env files, since this is now used for all containers including Grafana
• Change to powerwall.yml to use "unless-stopped" as the default restart policy for containers going forward (testing/research shows this may be a better choice, happy to discuss/explain my reasoning)

Also:

• Update other Docker Hub upload scripts to include your verification of specific version
• Add optional 3rd argument to compose-dash.sh script, which is useful sometimes to pass additional arguments to docker compose (e.g. being able run "compose-dash.sh up -d --remove-orphans" due to docker compose container changes could be handy)

Please review, and happy for you to modify as you see fit, or let me know if you see any issues with the changes.

[jasonacox]

Nice! Here is what this does:

• It replaces all occurrences of "GRAFANAUSER" with "PWD_USER" in the compose.env file.
• It checks if a line starting with "PWD_USER=" followed by "1000:1000" exists in the file. If it does, it comments out that line by adding a "#" at the beginning. This is because the powerwall.env will default to that.

[mcbirse]

Yep - all defaults are set in the powerwall.yml docker compose file now when a variable is undefined.

[jasonacox]

Thanks @mcbirse - This makes sense. In fact, had me wonder if we should just include all arguments. Should we just use $@ which would be all arguments?

[mcbirse]

Hi Jason, I agree, it would probably make sense to simply use $@ so there is no limit on the number of additional arguments that could be passed. Please feel free to update it.

[jasonacox]

GREAT additions @mcbirse! Thank you! 🙏 I'm going to start testing this before we merge...

First pass of verify.sh after upgrade.sh:

[jasonacox]

I'm seeing some issues with the Power Flow animation where a light gray border appears around the animation. I need to investigate...

I'm seeing JavaScript errors as the resize for the animation happens.

I'm going to try different Grafana versions to see if this is a bug or a conflict with our code. If it is a conflict, I'll likely revert the Grafana upgrade with the PW_STYLE=clear option in pypowerwall.env for anyone who wants to experiment with newer Grafana versions to get it to work.

[jasonacox]

I was finally able to get a clean run (no JavaScript errors) with Grafana v9.2.20. The border artifacts go away and the animation looks good with PW_STYLE=clear and PW_STYLE=grafana-dark. However, pushing it to recompute based on date ranges and other standard tasks I would do, did produce some JavaScript errors but not related to the animation.

From my testing (one version at a time) I discovered that something changed with v9.3+ that causes problems with our iFrame animation code and auto-resizing, specifically the border artifacts and JS errors. At v9.5 a different panel title formatting is introduced that seems to break the look as well. I think it will require a lot more investigation.

I'm reverting the upgrade of Grafana and keeping it at v9.1.2 as it seems the most stable in my testing. It also works well with both clear and grafana-dark modes. I'm going to continue to investigate how we get to a newer version. The other updates make sense to push forward and having grafana-dark as the default will help any others exploring newer Grafana version, including the ones raised in the Issues and Discussions.

[jasonacox]

v2.10.0 has been released....

• Tested Upgrade - no issues
• Tested Clean Install - no issues

[jgleigh]

@jasonacox Getting this error while trying to upgrade:
sed: 1: "compose.env": command c expects \ followed by text

[mcbirse]

Hey @jgleigh - I have pushed a quick fix to the upgrade script which should hopefully fix this problem. 🤞

I looked into this error, and it appears to be a compatibility issue between GNU sed (Linux based) and BSD sed (used in Mac OS). Are you using Mac?

It seems sed -i (update in-place with no backup file) does not work on Mac. Instead it expects a backup file, whereas on Linux this is accepted and will skip creating the backup file.

sed -i'' would be acceptable on both platforms to skip creating the backup file. However I decided to change the command to sed -i.bak to create the backup file anyway, as this is consistent with use of sed throughout the other scripts so must work across all platforms (hopefully).

Let us know if the upgrade works for you now.

[jgleigh]

@mcbirse That fixed it! Yes this was on a Mac. Thanks again.

[jasonacox]

Thanks @jgleigh for spotting the issue and thank @mcbirse for the fix!