Use {DeviceName} instead of {DeviceID} alternatively for API commands #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonacox
reviewed
May 22, 2023
server/server.py
Outdated
Comment on lines
388
to
392
| if(id not in deviceslist): | ||
| for key in deviceslist: | ||
| if deviceslist[key]['name'] == urllib.parse.unquote(id): | ||
| id = deviceslist[key]['id'] | ||
| break |
There was a problem hiding this comment.
Minor note: Since we are repeating this same logic 6 times, should we consider making this a function?
There was a problem hiding this comment.
Yes, of course. I was unsure to put it into a function... I will change it accordingly.
There was a problem hiding this comment.
I would also pull the urllib.parse.unquote(id) out of the loop and move it to a variable beforehand instead.
There was a problem hiding this comment.
I included both suggestions: getDeviceIdByName as a function and pull urllib.parse.unquote(id) out of the loop.
|
Thanks, @mschlenstedt ! Nice addition. # by DeviceID
$ curl http://localhost:8888/status/xxxxxxxxxxxxxxxxxx01
{"devId": "xxxxxxxxxxxxxxxxxx01", "dps": {"1": true, "9": 0}}
# by DeviceName
$ curl http://localhost:8888/status/Kitchen%20Light
{"devId": "xxxxxxxxxxxxxxxxxx01", "dps": {"1": true, "9": 0}}
$ curl http://localhost:8888/status/SmartBulb
{"devId": "xxxxxxxxxxxxxxxxxx02", "dps": {"20": true, "21": "white", "22": 1000, "24": "000003e803e8", "25":"07464602000003e803e800000000464602007803e803e80000000046460200f003e803e800000000464602003d03e803e80000000046460200ae03e803e800000000464602011303e803e800000000", "26": 0}}I updated the build to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the possibility to use {DeviceName} instead of {DeviceID} in API commands for a more convinient way to set up API calls. If one uses {DeviceName} the Device Names must be absolutely unique, of course.