Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Contrib support for Inverter Heat Pump such as Fairland IPHR55 #368

Conversation

valentindusollier
Copy link
Contributor

This adds support for Inverter Heat Pump such as Fairland Inverter+ 21kW (IPHR55).

@valentindusollier
Copy link
Contributor Author

I made the dotenv module optional. It is only use in /testcontrib.py in order to load environment variables from .env file. However it's not really needed. Moreover, this module is not installed in the workflows.

@uzlonewolf
Copy link
Collaborator

I do like the idea, but unfortunately python-dotenv only supports Python v3.8+ which is a bit too restrictive. At some point we should probably rework the whole contrib test system to add tests like this for the other contrib modules as well.

@valentindusollier
Copy link
Contributor Author

Yes, you're right. I think the right way to go for now is to remove it from requirements.txt and leave it as optional in /testcontrib.py. This way those who have the module installed can use it but /testcontrib.py works fine without dotenv as well. What do you think ?

@uzlonewolf
Copy link
Collaborator

Yes, that sounds good.

@valentindusollier
Copy link
Contributor Author

Done ✅

@jasonacox jasonacox merged commit d804359 into jasonacox:master Jun 20, 2023
5 of 10 checks passed
@jasonacox
Copy link
Owner

Thanks @valentindusollier !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants