fix(language-service): do not crash when hovering over a label defini…

…tions (angular#17974) Fixes: angular#17972
jasonaden · Jul 8, 2017 · 38f2670 · 38f2670
1 parent 9c3217d
commit 38f2670
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/packages/language-service/src/locate_symbol.ts b/packages/language-service/src/locate_symbol.ts
@@ -68,7 +68,7 @@ export function locateSymbol(info: TemplateInfo): SymbolInfo|undefined {
             }
           },
           visitReference(ast) {
-            symbol = info.template.query.getTypeSymbol(tokenReference(ast.value));
+            symbol = ast.value && info.template.query.getTypeSymbol(tokenReference(ast.value));
             span = spanOf(ast);
           },
           visitVariable(ast) {},

diff --git a/packages/language-service/test/hover_spec.ts b/packages/language-service/test/hover_spec.ts
@@ -68,6 +68,16 @@ describe('hover', () => {
         'property name of TestComponent');
   });
 
+  it('should be able to ignore a reference declaration', () => {
+    addCode(
+        ` @Component({template: '<div #«chart»></div>'}) export class MyComponent {  }`,
+        fileName => {
+          const markers = mockHost.getReferenceMarkers(fileName) !;
+          const hover = ngService.getHoverAt(fileName, markers.references.chart[0].start);
+          expect(hover).toBeUndefined();
+        });
+  });
+
   function hover(code: string, hoverText: string) {
     addCode(code, fileName => {
       let tests = 0;