Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better readablility for solution texts #38

Closed
blinry opened this issue Apr 2, 2019 · 1 comment · Fixed by #40
Closed

Better readablility for solution texts #38

blinry opened this issue Apr 2, 2019 · 1 comment · Fixed by #40
Labels
enhancement front-end Relating to the client-side JavaScript help wanted

Comments

@blinry
Copy link
Collaborator

blinry commented Apr 2, 2019

Especially green text on grey background is hard to read for my eyes (but that might be my color vision deficiency speaking). Anyhow, I'd suggest putting a background behind the text, or adding a text-shadow.
screenshot-2019-04-02_16:12:20
@jasonaowen
Copy link
Owner

@blinry yes, it's hard for me to read, as well!

@jaryncolbert jaryncolbert mentioned this issue Apr 5, 2019
Merged
jaryncolbert added a commit to jaryncolbert/recurse-faces that referenced this issue Apr 5, 2019
@jaryncolbert
CSS changes to make hint/guess text stand out against darker background
5efc583 
Issue jasonaowen#38: Better readability for solution texts
@jasonaowen jasonaowen added the front-end Relating to the client-side JavaScript label Apr 5, 2019
jaryncolbert added a commit to jaryncolbert/recurse-faces that referenced this issue Apr 8, 2019
@jaryncolbert
Issue jasonaowen#38: Better readability for solution texts Change px …
f33ea1e 
…widths and padding to ems
jaryncolbert added a commit to jaryncolbert/recurse-faces that referenced this issue Apr 8, 2019
@jaryncolbert
Issue jasonaowen#38: Better readability for solution texts
10a4851 
Change hint text from red to light blue to differentiate from guess
jaryncolbert added a commit to jaryncolbert/recurse-faces that referenced this issue Apr 9, 2019
@jaryncolbert
CSS changes to make hint/guess text stand out against darker background
c6c99d3 
Issue jasonaowen#38: Better readability for solution texts
jaryncolbert added a commit to jaryncolbert/recurse-faces that referenced this issue Apr 9, 2019
@jaryncolbert
Issue jasonaowen#38: Better readability for solution texts Change px …
a24fc77 
…widths and padding to ems
jaryncolbert added a commit to jaryncolbert/recurse-faces that referenced this issue Apr 9, 2019
@jaryncolbert
Issue jasonaowen#38: Better readability for solution texts
b87cfd0 
Change hint text from red to light blue to differentiate from guess
jaryncolbert added a commit to jaryncolbert/recurse-faces that referenced this issue Apr 18, 2019
@jaryncolbert
CSS changes to make hint/guess text stand out against darker background
1662db0 
Issue jasonaowen#38: Better readability for solution texts
jaryncolbert added a commit to jaryncolbert/recurse-faces that referenced this issue Apr 18, 2019
@jaryncolbert
Issue jasonaowen#38: Better readability for solution texts Change px …
6b7b8e5 
…widths and padding to ems
jaryncolbert added a commit to jaryncolbert/recurse-faces that referenced this issue Apr 18, 2019
@jaryncolbert
Issue jasonaowen#38: Better readability for solution texts
1811722 
Change hint text from red to light blue to differentiate from guess
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement front-end Relating to the client-side JavaScript help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CSS changes to make hint/guess text stand out against darker background jaryncolbert/recurse-faces
2 participants
@blinry @jasonaowen