Update RPM packaging #221
Closed
Update RPM packaging #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This installs config files, rather than just their examples. I'm not sure if I want to do that. By installing "examples", we can overwrite them on upgrade so a valid example is always available. Plus many installation scenarios don't require a configuration file, so I'm not sure this is actually an improvement here. |
|
How about this then? I think it's pretty important to install the config files with proper permissions. |
|
I can add a default config file with the correct permissions, but the file has to be blank I think. The examples are not good as a default. |
|
I guess I would suggest a completely commented out version. |
|
Closing. The RPM and Debian packages will no include a minimal configuration file that suits 90% of most peoples needs. |
jasonish
added a commit
that referenced
this pull request
Feb 21, 2023
As for the .deb, remove the sysconfig/defaults file but respect it if it exists. Also provides a default config. Also addresses most of the issues brought up in #221.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to do a few things:
This is untested as I don't have the ability to build evebox and evebox RPMs with fpm at the moment.