Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: rulecat report only if needed #49

Closed
sevdog opened this issue Apr 28, 2017 · 1 comment
Closed

Improvement: rulecat report only if needed #49

sevdog opened this issue Apr 28, 2017 · 1 comment

Comments

@sevdog
Copy link

sevdog commented Apr 28, 2017

Rulecat script when using the option --merged always generate a report as you can see in the code, WHICH is logged with level INFO.

If the option -q or --quiet is given this results in an unnecessary execution, because the report is generated but never logged, because the loggin level raises to WARNING.

This code shoul be preceeeded by an if statement that checks if the logging level will permit report display before generating it.

jasonish added a commit that referenced this issue May 2, 2017
It actually saves a lot of time.

Issue: #49
@jasonish
Copy link
Owner

jasonish commented May 2, 2017

Thanks. Fix applied. Report will not be generated with --quiet. I might have to rethink the report generation. Its only a half done feature anyways, with the idea of generating a full detailed report.

@jasonish jasonish closed this as completed May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants