Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android beta support #18

Merged
merged 5 commits into from
Apr 9, 2016
Merged

Android beta support #18

merged 5 commits into from
Apr 9, 2016

Conversation

HazemKhaled
Copy link
Collaborator

Adding beta Android support, UI working fine, but i've to test listener and HeaderView, also pickers ot touched yet

fix #4

screen shot 2016-04-06 at 3 44 10 pm

@FokkeZB
Copy link
Collaborator

FokkeZB commented Apr 8, 2016

Thanks @HazemKhaled! Could you let me know when you have finished this up?

@HazemKhaled
Copy link
Collaborator Author

I'm working on a new project right now and using this widget, the plan to
fix only any bug I'll face.

I think better to make sure this commits will not break the iOS features,
at least now text field, sections, headerTitle and footerTitle working on
both iOS and Android, anything else still working fine on iOS and not
tested on Android

On Fri, Apr 8, 2016, 10:23 AM Fokke Zandbergen notifications@github.com
wrote:

Thanks @HazemKhaled https://github.com/HazemKhaled! Could you let me
know when you have finished this up?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#18 (comment)

Regards,
Hazem Khaled | Software Engineer | About Me ...
http://about.me/HazemKhaled
Mob: +20 122 7660 187
+971 52 815 6993

@@ -1,26 +1,29 @@
".row[platform=ios]": {
selectionStyle: Ti.UI.iPhone.TableViewCellSelectionStyle.NONE,

layout: 'horizontal'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove horizontal layout?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TextField width on Android filling the row, don't know why, not layout is composite, #control left now is 160

@HazemKhaled
Copy link
Collaborator Author

HeaderView and FooterView working fine on both iOS and Android

@FokkeZB FokkeZB merged commit 44788d0 into jasonkneen:master Apr 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android support
2 participants