Fix: Jade plugin extension functionality #15
Conversation
|
@sch Thanks for putting this together! I have few questions but generally looks great. Lets get this merged soon. |
|
|
||
| const template = createTemplate(config.templateExtension) | ||
| const render = createRenderer(config.jade, config.templateExtension) |
There was a problem hiding this comment.
Here we are adding a new config field jade to allow the user to customize jade's compile options, right? However I believe this is what the existing option compile was for. If I am right about your intention here then I think we should revise this code to be config.compile [1].
[1] The field name may be questionable but lets keep that for a different issue so that we can relegate this PR to a bug fix with no interface change.
There was a problem hiding this comment.
Ahh, thanks — I wasn't sure if you were thinking that would be reserved for the Webpack compiler or the Jade compiler. Updated!
Currently, the function that creates the Jade render function is always being called with an extension template value of `null`. This change fixes the call site to pass the `compiler` settings object and the extension template to the Jade `createRenderer` function.
…mpiler-settings Fix: Jade plugin extension functionality
|
Thanks again! |
|
I will cut a release later today when I'm at my computer proper. |
Currently, the function that creates the Jade render function is always being called with an extension template value of
null. This change fixes the call site ofcreateRendererto pass thecompilesettings object and the extension template to the Jade compiler.I also made some naming changes, as I was getting confused about our terminology vs the Jade terminology — namely
createTemplate→createRenderer, since that's how the Jade api refers to it.