Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Explicit Chalk Dependency & Build Script #61

Closed
wants to merge 2 commits into from

Conversation

Alec2435
Copy link

@Alec2435 Alec2435 commented Mar 8, 2022

This PR does two things

  1. Adds an explicit dependency on Chalk as otherwise certain package managers would incorrectly link the wrong version and as a result, Floggy wouldn't work
  2. Add the build script to a "prepare" script to allow installing this package directly from Github. This is because otherwise Yarn/NPM don't know what to run to build the package when installing directly from the repo.

Copy link

@habovh habovh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this PR. The lack of having explicitly set chalk as a dependency or a peer dependency results in chalk being pruned when pruning dev dependencies. This leads to broken apps on Heroku for examples, or having to resort to keep all dev dependencies.

@jasonkuhrt
Copy link
Owner

Sorry @Alec2435 I missed this PR somehow. I've just fixed this though and will be cutting a new release soon fwiw. Thanks for the effort you put in here!

@jasonkuhrt jasonkuhrt closed this Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants