feat: add support for get request #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoinelin
commented
Jul 19, 2021
| @@ -1,7 +1,7 @@ | |||
| import crossFetch, * as CrossFetch from 'cross-fetch' | |||
| import { print } from 'graphql/language/printer' | |||
| import createRequestBody from './createRequestBody' | |||
| import { ClientError, GraphQLError, RequestDocument, Variables } from './types' | |||
| import { ClientError, RequestDocument, Variables } from './types' | |||
There was a problem hiding this comment.
Removed GraphQLError as it is not in use
antoinelin
commented
Jul 19, 2021
| * Fetch data using POST method | ||
| */ | ||
| const post = async <V = Variables>( | ||
| url: string, |
There was a problem hiding this comment.
I followed the way you declare functions to keep consistency but I'm not a huge fan of using too much args here and I spend much time to think if I should use a typed object here. Tell me if it is okay for you or if you want me to change this
|
Before back and forth/review is done and the PR merged/closed, I published a working version of my fork on NPM you may find here : https://www.npmjs.com/package/@vahill/graphql-request |
This was referenced Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃枛馃徎 Hello Prisma team,
Here is a proposal to provide support for GET requests.
Should resolve #61 and #260