fix: include source files in package for source maps #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willstott101
changed the title
alec-oms
approved these changes
Feb 1, 2022
buskerone
approved these changes
Feb 2, 2022
jasonkuhrt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#311 details how source maps are broken - they refer files in the
srcdirectory which aren't included in the installed package.This is the easiest fix for this problem. There is no fix which doesn't increase the size of the package other than completely removing the source maps unfortunately.
I've taken this approach rather than embedding the source in the map files as that's what we decided elsewhere in the graphql ecosystem: graphql/graphiql#2047