Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add documentation for onRequestClose function #32

Merged

Conversation

alaskaa
Copy link
Contributor

@alaskaa alaskaa commented Oct 2, 2019

Hey 馃憢

First of all, thank you for such a great library - it worked beautifully for my usecase and I found it very straightforward to use.

I've noticed you didn't very openly advocate the inbuilt function "onRequestClose" and therefore thought it would be awesome to add it to the docs.

I discovered it more or less by accident, and it provided me with the opportunity to leave the modal and return to a previous modal which was very useful. Happy to rework the PR or add the info at another stage, but I think it would be awesome if it is documented somehow that it can be used to close the dropdowns or modals!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 64

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.538%

Totals Coverage Status
Change from base Build 63: 0.0%
Covered Lines: 24
Relevant Lines: 24

馃挍 - Coveralls

@codecov-io
Copy link

Codecov Report

Merging #32 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #32   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          24     24           
=====================================
  Hits           24     24

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 7d4ccba...9ec5d49. Read the comment docs.

@jasonleibowitz
Copy link
Owner

@alaskaa Apologies for the delayed response. This is a great call out. Thanks for the PR!

@jasonleibowitz jasonleibowitz merged commit 6206080 into jasonleibowitz:master Dec 24, 2019
@jasonleibowitz jasonleibowitz added this to the v1.0.10 milestone Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants