Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

footer references hr.png which is not in the images folder #12

Closed
roryprimrose opened this issue Feb 24, 2015 · 7 comments · Fixed by #14
Closed

footer references hr.png which is not in the images folder #12

roryprimrose opened this issue Feb 24, 2015 · 7 comments · Fixed by #14

Comments

@roryprimrose
Copy link

No description provided.

@jonorossi
Copy link

See #2 and #3.

@roryprimrose
Copy link
Author

My bad, I only reviewed open issues. Thanks :)

On 24 Feb 2015, at 5:04 pm, Jonathon Rossi notifications@github.com wrote:

See #2 and #3.


Reply to this email directly or view it on GitHub.

@roryprimrose
Copy link
Author

This file is still referenced in the style for footer, line 750

@jonorossi
Copy link

@roryprimrose ah, my bad I thought it was all fixed in #3.

@jasonlong
Copy link
Owner

Thanks @jonorossi. I've removed the footer style complete since this theme doesn't use that element. It looks like I copy/pasted this from my other theme.

@jonorossi
Copy link

@jasonlong interesting, I must have looked at the CSS or just guessed when I did http://www.castleproject.org/, because I've got a footer on it. I don't mind the change, I'll probably never update it directly because there are heaps of customisations already.

https://github.com/castleproject/castleproject.github.io/blob/master/_layouts/default.html#L95

Thanks for the awesome theme too.

@jasonlong
Copy link
Owner

Ah right on. I might revisit this later and move some of the sidebar content down to a real footer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants