Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iTunes is confused - wrong tracks listed against albums, artists #49

Closed
stormcock opened this issue Apr 23, 2011 · 5 comments
Closed

iTunes is confused - wrong tracks listed against albums, artists #49

stormcock opened this issue Apr 23, 2011 · 5 comments

Comments

@stormcock
Copy link

v0.15. Selecting a particular album, or an artist, in iTunes with the Column browser, the track listing will almost always show one spurious track from a different artist or album, and often one legitimate track will be missing. See screenshot (iTunes 10.1.0.56). For comparison, not the case with a firefly/mtdaapd server.

@peterjc
Copy link
Contributor

peterjc commented Apr 23, 2011

Sounds like an off by one error. Had you seen this on older versions of forked-daapd?

@ldesgrange
Copy link

Same here. I noticed that when I upgraded from 0.14 to 0.15. I rebuilt the database but the problem persist (interestingly the same tracks where mixed up the same way).
What I noticed is that all the tags of the song are correct except the "sort *" tags (sort name, sort artist…).
By the way, other songs that seem to be well sorted also have the "sort name" tag mixed up with the name of other songs from the same album.

@stormcock
Copy link
Author

OK, I see the reason now. In response to a /items request, server sends the first track OK, but each subsequent track contains extra sort data related to the previous track (assn:daap.sortname, assa:daap.sortartist, assu:daap.sortalbum, assl:daap.sortalbumartist and assc:daap.sortcomposer). So even when these fields are requested specifically, or all meta is requested, the incorrect data comes first - and presumably iTunes detects the first instance and ignores subsequent ones. The incorrect data comes immediatley after the asdk:daap.songdatakind field. Did I explain this OK?

Seems to occur whenever info for a number of items is returned, e.g. requesting all items, or with a query in the 'items' url.

@stormcock stormcock reopened this Apr 24, 2011
@peterjc
Copy link
Contributor

peterjc commented Apr 30, 2011

Does this fix it?

a70a45d

@stormcock
Copy link
Author

Yes, this fixes, thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants