Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing controller.isDirty default logic #10

Closed
blimmer opened this issue May 5, 2016 · 4 comments
Closed

Removing controller.isDirty default logic #10

blimmer opened this issue May 5, 2016 · 4 comments
Milestone
0.4.0

Comments

@blimmer
Copy link
Collaborator

blimmer commented May 5, 2016 •
edited

To be good Ember community members, we should discourage the use of Ember.Controller.

It would be a breaking change, but perhaps we should guide users to provide their own canUnload or have logic that utilizes this.modelFor(this.routeName) instead.
@jasonmit jasonmit closed this as completed May 5, 2016
@jasonmit jasonmit reopened this May 5, 2016
@jasonmit
Copy link
Owner

jasonmit commented May 5, 2016

Was reading on my phone, didn't mean to close :). Is your concern that controllers are going away?

@blimmer
Copy link
Collaborator Author

blimmer commented May 5, 2016

Yep!

@blimmer blimmer mentioned this issue May 5, 2016
Closed
@blimmer blimmer added this to the 0.4.0 milestone May 5, 2016
@jasonmit
Copy link
Owner

jasonmit commented May 6, 2016

I'm down to move this responsibility to the route, unless you have some other ideas.

@blimmer
Copy link
Collaborator Author

blimmer commented May 6, 2016

Sounds great - I'll update the title.

@blimmer blimmer changed the title Consider removing controller.isDirty default logic Removing controller.isDirty default logic May 6, 2016
blimmer added a commit that referenced this issue May 15, 2016
@blimmer
Don't rely on controller isDirty.
c769252 
By default, we will check if the current route model hasDirtyAttributes.
Resolves #10.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
2 participants
@blimmer @jasonmit