Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🕷 [Inline View] Deleting checked EMails does not work #299

Closed
ulfgebhardt opened this issue Nov 3, 2018 · 2 comments
Closed

🕷 [Inline View] Deleting checked EMails does not work #299

ulfgebhardt opened this issue Nov 3, 2018 · 2 comments
Assignees
@jasonmunro
Labels
awaiting feedback please follow up! bug something is wrong in Cypht inline_message inline message module set

Comments

@ulfgebhardt
Copy link
Contributor

🕷 Bugreport

[Inline View] Deleting checked EMails does not work

Deleting an EMail with the In-EMail-Header-Delete Button does not work if the EMail is checked.

Screeny

image

Version

2f06317

Relates

This relates to several previous issues like
@jasonmunro jasonmunro self-assigned this Nov 5, 2018
@jasonmunro jasonmunro added bug something is wrong in Cypht inline_message inline message module set labels Nov 5, 2018
jasonmunro added a commit that referenced this issue Nov 5, 2018
@jasonmunro
fix for inline message view delete issue #299
e0701cf
@jasonmunro
Copy link
Member

Fix is in the master branch in e0701cf . Let me know if it works for you and I will apply it to the release candidate as well. As always, thanks for the feedback!

(This was a race condition between event handlers BTW. l also added a bit of logic to remove the deleted message from the list on delete rather than waiting for the entire list to update).

@jasonmunro jasonmunro added the awaiting feedback please follow up! label Nov 5, 2018
jasonmunro added a commit that referenced this issue Nov 6, 2018
@jasonmunro
fix for inline message view delete issue #299
94b1c56
@ulfgebhardt
Copy link
Contributor Author

Confirming Fix!

Thanks <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonmunro jasonmunro

Labels
awaiting feedback please follow up! bug something is wrong in Cypht inline_message inline message module set
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ulfgebhardt @jasonmunro