Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme updates #23

Merged
merged 13 commits into from
Jan 27, 2018
Merged

Readme updates #23

merged 13 commits into from
Jan 27, 2018

Conversation

elsassph
Copy link
Collaborator

@elsassph elsassph commented Jan 25, 2018

Rewrote readme to match other Webpack loaders presentation, and moved interesting Webpack tips in a separate file.

Also added cute icons at the top of the page :)

Preview: https://github.com/elsassph/webpack-haxe-loader/tree/readme

Copy link
Owner

@jasononeil jasononeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing work, thanks so much.

I've got a couple of small changes that I think would make for better grammar. If you can update that would be great, otherwise I will when I get a chance :)

Thanks again! It reads so much better.

README.md Outdated
"test_watch": "cd www && nodemon test.js"
},
HXML files are a way to specify Haxe compiler arguments; for this loader, configure
the compiler as for any Haxe-JavaScript project, and add `-lib haxe-loader`:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using -lib haxe-loader isn't actually necessary unless using the Webpack class, and you mention that in the section below. Maybe you can end the sentence "as for any Haxe-JavaScript project."

README.md Outdated

To require 3rd party NPM modules, you can use `@:jsRequire` metadata or
[`js.Lib.require()`](http://api.haxe.org/js/Lib.html#require).

However, those requires are relative to you HXML file!
It also cannot be compiled on platforms other than JS.

It is thus recommended to call instead:
For assets/styles, it is thus recommended to call instead:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "it is therefore recommended" sounds better ("thus" seems quite formal to me, but maybe that's because I'm aussie)

README.md Outdated

### Contributing
## Contributing

Don't hesitate to create a pull request. Every contribution is appreciated.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add something for bug reports?

If you encounter a bug, please open a Github issue. As webpack configuration can differ greatly between projects, it is helpful if you can reproduce the bug using our example repository as a starting point.

webpack-tips.md Outdated
@@ -0,0 +1,134 @@
# Why using Webpack for Haxe developers?
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe

How is Webpack useful for Haxe developers?

There are several reasons to use Webpack when working on a Haxe Javascript project: ....

@jasononeil jasononeil merged commit b333aff into jasononeil:master Jan 27, 2018
@elsassph elsassph deleted the readme branch April 23, 2018 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants