Fix Webpack.require() when file is outside cwd #37
Conversation
haxelib/Webpack.hx
Outdated
| @@ -126,7 +128,7 @@ class Webpack { | |||
| } | |||
|
|
|||
| if (directory != '') { | |||
| return './${directory}/${file}'; | |||
| return '${directory}/${file}'; | |||
| } | |||
| if (file.startsWith('.')) { | |||
There was a problem hiding this comment.
Shouldn't this be '..' instead of '.'?
There was a problem hiding this comment.
I think we need unit tests here before changing the behaviour.
There was a problem hiding this comment.
Sure. I don't have too much time for that atm though =/
There was a problem hiding this comment.
Yeah this is a bit sensitive so I'll try to write some
kLabz
force-pushed
the
fix/require-absolute-directory
branch
5 times, most recently
from
d2dc156
to
2b3dd9d
Compare
test/src/HaxeTests.hx
Outdated
| assert(rebaseRelativePath('src/a/b', './res') == './src/a/b/res'); | ||
| assert(rebaseRelativePath('src/a/b', '../res') == './src/a/res'); | ||
| assert(rebaseRelativePath('src/a/b', '../../res') == './src/res'); | ||
| assert(rebaseRelativePath('src', './res') == 'src/res'); |
There was a problem hiding this comment.
I think the cases should be modified to be like rebaseRelativePath('./src', './res'), and adding some dummy absolute paths, because that's what comes our the relativePath function now.
There was a problem hiding this comment.
I started and yep, needs more work on both the tests and the implementation. I'll try to update this week-end (or maybe before if I find some time).
kLabz
force-pushed
the
fix/require-absolute-directory
branch
from
2b3dd9d
to
bd1afa8
Compare
kLabz
force-pushed
the
fix/require-absolute-directory
branch
3 times, most recently
from
a533235
to
add97a3
Compare
kLabz
force-pushed
the
fix/require-absolute-directory
branch
from
add97a3
to
71aa41b
Compare
I am using a strange environment where the main sources are outside the
cwd.When requiring with
Webpack.require(), I end up with paths like.//my/absolute/path/to/src/file.scsswhich don't work.I tested this version with all my projects, it worked fine. I don't know about windows nor how far the test suite goes in testing this kind of things, though.
Now including changes from #36 too: