Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack 5 requires dependencies to be absolute path #80

Merged
merged 3 commits into from
Feb 24, 2022

Conversation

elsassph
Copy link
Collaborator

@elsassph elsassph commented Feb 23, 2022

  • ensure classpath and watch paths are absolute
  • fix regression in hxml parsing (with test)

@clarkjones
Copy link

Getting a build error:

Module build failed (from ./node_modules/haxe-loader/index.js):
Haxe Loader: Compilation failed

This appears to be a problem introduced in an earlier update though. I went ahead made the same changes in my local 0.10.0 release and it built fine.

yargs-parser seems to be the only version bump with a new major version so maybe that?

@clarkjones
Copy link

ok here's a follow up.
Reverting yargs-parser did work for me.
After a little research I found there is an issue with parsing quotes in updated versions. My web pack build uses --macro "include('...')" in the extra` option
shell-parser seems to be a working alternative.

@elsassph
Copy link
Collaborator Author

@clarkjones indeed there was a subtle change in yargs-parser tokenization (for the better). It should be fixed now.

@clarkjones
Copy link

ok, works for me now. thanks

@elsassph elsassph merged commit 5ab6bef into jasononeil:master Feb 24, 2022
@elsassph elsassph deleted the fix/absolute-paths branch February 24, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants