Skip to content

Commit

Permalink
[TEAMMATES#12265] Modify minimum page height to factor in footer heig…
Browse files Browse the repository at this point in the history
…ht (TEAMMATES#12406)

* Edited css main-height variable to calculate footer position based on screen width

* Added another case if the screen width is below 314px (Which will probably never happen)

* Removed extra space and end of lines

* Update src/web/app/page.component.scss by removing the footer case for 313px width and below

Co-authored-by: Zhao Jingjing <54243224+zhaojj2209@users.noreply.github.com>

* Removed 590px or above case and below 313px case for screen width

---------

Co-authored-by: Ryan Lin <ryanlin@ryans-mbp-9.wifi.local.cmu.edu>
Co-authored-by: Zhao Jingjing <54243224+zhaojj2209@users.noreply.github.com>
Co-authored-by: Ryan Lin <ryanlin@Ryans-MacBook-Pro-9.local>
Co-authored-by: Wei Qing <48304907+weiquu@users.noreply.github.com>
  • Loading branch information
5 people committed Apr 27, 2023
1 parent 2718d3c commit a4d335d
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion src/web/app/page.component.scss
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,22 @@ nav {

.main-content {
margin-top: 50px;
min-height: calc(100vh - 80px);
min-height: calc(100vh - 102px);
padding: 20px 70px;
}

@media (max-width: 575px) {
.main-content {
min-height: calc(100vh - 144px);
}
}

@media (min-width: 576px) and (max-width: 589px) {
.main-content {
min-height: calc(100vh - 123px);
}
}

.footer {
padding: 5px 70px;
color: rgba(255, 255, 255, .75);
Expand Down

0 comments on commit a4d335d

Please sign in to comment.