Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

base64urlencode as optional #15

Merged
merged 3 commits into from
Apr 26, 2021
Merged

base64urlencode as optional #15

merged 3 commits into from
Apr 26, 2021

Conversation

klerick
Copy link

@klerick klerick commented Apr 26, 2021

No description provided.

@klerick klerick mentioned this pull request Apr 26, 2021
Closed
@jasonraimondi
Copy link
Owner

jasonraimondi commented Apr 26, 2021 •
edited
Loading

@klerick Thank you for submitting this, it is great! I have one request for change:

  • If you can just add this use case as a separate test with a properly defined test case, something like "auth server succeeds when skipping base64encode" instead of combining it with the pkce test.

I will get this merged in and tagged as the next version

@klerick
Copy link
Author

klerick commented Apr 26, 2021

done, if i understand you correctly :)

@jasonraimondi jasonraimondi merged commit d3ed5d3 into jasonraimondi:master Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@klerick @jasonraimondi