Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified method data handling and fix #57 #58

Merged
merged 1 commit into from
Jan 30, 2014

Conversation

chaizhenhua
Copy link
Contributor

hello, Jason
I write a patch to fix #57. this patch use class instance variable table to store method data without dummy meta class. can you have a look?

@jasonroelofs
Copy link
Collaborator

That's quite a change to the fundamental internals of how Rice works, and according to Travis these changes lead to a broken test suite for Ruby 1.8.7. I'll spend some time with these, maybe I'll look into a Rice 2.0 version bump that deprecates Ruby 1.8 support if that's the only thing these changes break.

@chaizhenhua
Copy link
Contributor Author

hello, the new patch fixed the unittest.

@chaizhenhua
Copy link
Contributor Author

Hi, I updated the patch. Now it can pass the test.

@jasonroelofs
Copy link
Collaborator

Aye, and I thank you for looking into this. I simply haven't had the time lately to play with these changes to see that they aren't breaking anything else. Sorry for the wait, I'm going to try to carve some time out soon.

@jasonroelofs
Copy link
Collaborator

Apologies for the delay. I've run through a few scenarios and this change looks to be good, and as a bonus it makes Rice compatible with Ruby 2.1! So thanks for this for sure.

As a side note, as you can probably guess Rice isn't very high on my priority list at the moment. Are you working with it regularly, and would you like commit access?

jasonroelofs added a commit that referenced this pull request Jan 30, 2014
Modified method data handling and fix #57
@jasonroelofs jasonroelofs merged commit a572bf8 into ruby-rice:master Jan 30, 2014
@chaizhenhua
Copy link
Contributor Author

@jasonroelofs I do not use it too often, but I would like to contribute codes.

@jasonroelofs
Copy link
Collaborator

@chaizhenhua You are now a collaborator. Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

define_method && define_constructor does not inherit access specifier.
2 participants