Fixed so that useChance applies in last transition back to parent obj…

…ect (example: refilling last step of pond should have 1/5 chance of taking pond to full state, when before it had 1/1 chance, allowing for an infinite water exploit). Thanks Eve, YAHG, and Rebel.

documentation/changeLog.txt

@@ -3,6 +3,20 @@ This file only list changes to game code.  Changes to content can be found here:
 http://onehouronelife.com/updateLog.php
 
 
+
+
+
+Server Fixes:
+
+--Fixed so that useChance applies in last transition back to parent object
+  (example:  refilling last step of pond should have 1/5 chance of taking pond
+  to full state, when before it had 1/1 chance, allowing for an infinite water
+  exploit).  Thanks Eve, YAHG, and Rebel.
+
+
+
+
+
 Version 105   2018-June-1
 
 --Fixed crash in transition bank pattern code.  Thanks Enforcerke and Jookia.

gameSource/transitionBank.cpp

@@ -869,7 +869,16 @@ void initTransBankFinish() {
                             }
                         else if( uTo >= target->numUses - 1 ) {
                             tp.toID = newTarget->id;
-                            tp.noChangeID = newTarget->id;
+                            if( dir == 1 && tp.fromID != -1 ) {
+                                // transition back to parent object
+                                // if we have a use chance, it should
+                                // apply here too, leaving us at last use dummy
+                                // object if use chance doesn't happen.
+                                tp.noChangeID = tp.fromID;
+                                }
+                            else {
+                                tp.noChangeID = newTarget->id;
+                                }
                             }
 
                         if( tp.fromID != -1 && tp.toID != -1 ) {