Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound authorship inconsistencies #1114

Closed
connorhsm opened this issue Jul 22, 2024 · 2 comments
Closed

Sound authorship inconsistencies #1114

connorhsm opened this issue Jul 22, 2024 · 2 comments

Comments

@connorhsm
Copy link

connorhsm commented Jul 22, 2024

In regard to sound authorship for AHAP, I see a number of sounds have an accompanying .txt file with the author= prefix multiple times. See https://github.com/jasonrohrer/AnotherPlanetData/blob/395f3a1e7b7856f06485b4164ed1a12e2dee2720/sounds/100.txt showing author=author=author=author=102CA969F5

I've also added multiple sounds yesterday, but using the copyChangesToRepo script has not copied the .txt file with my authorship. Or the next sound number file!

@jasonrohrer
Copy link
Owner

Aha! Found the problem here...

So... the problem is in the exporter code, which reads the sound's .txt file, doesn't strip off the author= part, and then adds another author= part when exporting.

jasonrohrer added a commit that referenced this issue Aug 14, 2024
…iles for sound files included in export. Part of #1114
@jasonrohrer
Copy link
Owner

Also, those sound files with the author= tags can be fixed manually, with a text editor, and then committed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants