Delete row fix

jasonrollins · Mar 31, 2020 · 29b6d50 · 29b6d50
1 parent d5f6f64
commit 29b6d50
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 6 deletions.
diff --git a/shareplum/list.py b/shareplum/list.py
@@ -452,6 +452,8 @@ def update_list_items(self, data, kind, mutate_data=False):  # type: (List[Dict[
                 self._mutate_to_internal(spdata)
             else:
                 spdata = self._convert_to_internal(data)
+        else:
+            spdata = data
 
         soap_request.add_actions(spdata, kind)
         self.last_request = str(soap_request)

diff --git a/shareplum/version.py b/shareplum/version.py
@@ -1 +1 @@
-__version__ = "0.4.3"
+__version__ = "0.4.4"
diff --git a/tests/test_list.py b/tests/test_list.py
@@ -41,23 +41,31 @@ def test_c_update_list(self):
         print("Update List")
         self.list = self.site.List(self.server["test_list"])
         my_data = data=[{'Title': 'First Row!'},
-                        {'Title': 'Another One!'}]
+                        {'Title': 'Another One!'},
+                        {'Title': 'Thrid Row'}]
         self.list.UpdateListItems(data=my_data, kind='New')
+        self.assertEqual(len(self.list.get_list_items(row_limit=5)), 3)
+
+    def test_d_delete_row(self):
+        print("Delete Row")
+        self.list = self.site.List(self.server["test_list"])
+        my_data = data=[1]
+        self.list.UpdateListItems(data=my_data, kind='Delete')
         self.assertEqual(len(self.list.get_list_items(row_limit=2)), 2)
 
-    def test_d_get_view(self):
+    def test_e_get_view(self):
         print("Get View")
         self.list = self.site.List(self.server["test_list"])
         self.assertEqual(len(self.list.GetListItems("All Items")), 2)
 
-    def test_e_query_list(self):
+    def test_f_query_list(self):
         print('Test Query')
         self.list = self.site.List(self.server["test_list"])
-        query = {'Where': [('Eq', 'Title', 'First Row!')]}
+        query = {'Where': [('Eq', 'Title', 'Another One!')]}
         items = self.list.GetListItems(fields=['Title'], query=query) 
         self.assertEqual(len(items), 1)
 
-    def test_f_users(self):
+    def test_g_users(self):
         print("Test Users")
         self.list = self.site.List(self.server["test_list"])
         self.assertIsNotNone(self.list.users)