Add script/setup #11
Merged
Add script/setup #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeepers
commented
Jan 29, 2017
|
|
||
| # Enable accessibility - https://github.com/jacobsalmela/tccutil | ||
| # FIXME Doesn't work with SIP https://github.com/jacobsalmela/tccutil/issues/18 | ||
| # sudo tccutil -e org.hammerspoon.Hammerspoon |
There was a problem hiding this comment.
@MikeMcQuaid do you know any tricks to programmatically enable Accessibility?
MikeMcQuaid
reviewed
Jan 29, 2017
| @@ -0,0 +1,6 @@ | |||
| cask_args appdir: '/Applications' | |||
There was a problem hiding this comment.
This is the default now so can be dropped.
| ln -sf $PWD/hammerspoon ~/.hammerspoon | ||
|
|
||
| # Prepare custom settings for navigating between words in iTerm2 | ||
| cat $PWD/inputrc >> ~/.inputrc |
There was a problem hiding this comment.
Pedantry: may want to check the contents aren't already present to avoid appending multiple times.
jasonrudolph
requested changes
Jan 30, 2017
There was a problem hiding this comment.
Nice work, @bkeepers! 😻
I noticed just one small issue related to ~/.inputrc. Would you mind taking a look?
| ln -sfn $PWD/hammerspoon ~/.hammerspoon | ||
|
|
||
| # Prepare custom settings for navigating between words in iTerm2 | ||
| grep -q forward-word ~/.inputrc || cat $PWD/inputrc >> ~/.inputrc |
There was a problem hiding this comment.
If ~/.inputrc doesn't exist, this line fails with the following error:
grep: /Users/me/.inputrc: No such file or directory
There was a problem hiding this comment.
👍 Fixed by adding -s flag:
-s, --no-messages
Silent mode. Nonexistent and unreadable files are ignored (i.e.
their error messages are suppressed).
jasonrudolph
approved these changes
Jan 30, 2017
|
Thanks, @bkeepers! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the TODO in the README for adding
script/setup. This works on my machine, but there's still some cleanup: