bump react peer dependency #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know the repo is marked "INACTIVE", but is there any chance of this getting merged? |
|
sure, sorry for kept you waiting for this |
|
Thanks @jasonslyvia! |
|
Plan to release to npm? |
|
|
|
Thanks again @jasonslyvia, no worries |
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Mar 16, 2018
Now that jasonslyvia/react-anything-sortable#93 is merged and released we can upgrade our version and get rid of the incompatibility warning
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Mar 28, 2018
Now that jasonslyvia/react-anything-sortable#93 is merged and released we can upgrade our version and get rid of the incompatibility warning
spalger
added a commit
to elastic/kibana
that referenced
this pull request
Mar 28, 2018
Now that jasonslyvia/react-anything-sortable#93 is merged and released we can upgrade our version and get rid of the incompatibility warning
spalger
added a commit
to elastic/kibana
that referenced
this pull request
Mar 28, 2018
Now that jasonslyvia/react-anything-sortable#93 is merged and released we can upgrade our version and get rid of the incompatibility warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #83 it seems react-anything-sortable works fine with react 16. Tests also pass when forced to run with react 16.