possible solution to fix the issue #96 #150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aohua
commented
Jan 6, 2018
src/utils/scrollParent.js
Outdated
| @@ -27,7 +27,7 @@ export default (node) => { | |||
| continue; | |||
| } | |||
|
|
|||
| if (overflowRegex.test(overflow) && overflowRegex.test(overflowX) && overflowRegex.test(overflowY)) { | |||
| if (overflowRegex.test(overflow) || overflowRegex.test(overflowX) || overflowRegex.test(overflowY)) { | |||
There was a problem hiding this comment.
'LazyLoad Overflow should not detect an overflow container when only one of the scroll property is auto/scroll FAILED', I don't really get it, users may not want to use all of this 3 properties right?
There was a problem hiding this comment.
See here for further information about why use && instead of ||
There was a problem hiding this comment.
Thank you. That's good to know. However, this condition breaks the example in Chrome. My chrome version is Version 63.0.3239.84 (Official Build) (64-bit).
There was a problem hiding this comment.
I can try to fix it as well. Thanks for your reply.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my fix for issue #96. Not sure if it would work or not.