Code analysis and optimization

jasonsturges · Apr 6, 2019 · 49a7641 · 49a7641
1 parent 0410d5e
commit 49a7641
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 24 deletions.
diff --git a/README.md b/README.md
@@ -9,15 +9,15 @@ Example:
 
 ```js
 const fs = require("fs");
-const anf = require("apple-news-compiler")
+const anf = require("apple-news-compiler");
 
 const run = async () => {
-  var article = JSON.parse(fs.readFileSync("article.json"), 'utf8');
+  const article = JSON.parse(fs.readFileSync("article.json"), 'utf8');
 
   anf.article.inline(article);
 
   console.log(JSON.stringify(article, null, 2));
-}
+};
 
 run();
 ```
@@ -68,15 +68,15 @@ Example:
 
 ```js
 const fs = require("fs");
-const anf = require("apple-news-compiler")
+const anf = require("apple-news-compiler");
 
 const run = async () => {
-  var article = JSON.parse(fs.readFileSync("article.json"), 'utf8');
+  const article = JSON.parse(fs.readFileSync("article.json"), 'utf8');
 
   anf.article.removeUnusedReferences(article);
 
   console.log(JSON.stringify(article, null, 2));
-}
+};
 
 run();
 ```
@@ -92,15 +92,15 @@ Example:
 
 ```js
 const fs = require("fs");
-const anf = require("apple-news-compiler")
+const anf = require("apple-news-compiler");
 
 const run = async () => {
-  var article = JSON.parse(fs.readFileSync("article.json"), 'utf8');
+  const article = JSON.parse(fs.readFileSync("article.json"), 'utf8');
 
   anf.article.removeEmptyDefinitions(article);
 
   console.log(JSON.stringify(article, null, 2));
-}
+};
 
 run();
 ```

diff --git a/index.js b/index.js
@@ -7,7 +7,7 @@
 
 'use strict';
 
-const article = require("./lib/article")
+const article = require("./lib/article");
 
 module.exports = {
   article

diff --git a/lib/article.js b/lib/article.js
@@ -91,7 +91,7 @@ const removeComments = (article) => {
         traverser(article, child);
       });
     }
-  }
+  };
 
   article.components.forEach(component => {
     traverser(article, component)
@@ -112,7 +112,7 @@ const removeComments = (article) => {
   Object.keys(textStyles).forEach(textStyle => {
     removeComment(textStyles[textStyle]);
   });
-}
+};
 
 
 /**
@@ -131,21 +131,21 @@ const removeEmptyDefinitions = (article) => {
       if (util.isString(component["layout"]))
         if (componentLayouts.hasOwnProperty(component["layout"]))
           if (Object.keys(componentLayouts[component["layout"]]).length === 0)
-            delete component["layout"]
+            delete component["layout"];
 
     // Component styles
     if (component.hasOwnProperty("style"))
       if (util.isString(component["style"]))
         if (componentStyles.hasOwnProperty(component["style"]))
           if (Object.keys(componentStyles[component["style"]]).length === 0)
-            delete component["style"]
+            delete component["style"];
 
     // Component text styles
     if (component.hasOwnProperty("textStyle"))
       if (util.isString(component["textStyle"]))
         if (componentTextStyles.hasOwnProperty(component["textStyle"]))
           if (Object.keys(componentTextStyles[component["textStyle"]]).length === 0)
-            delete component["textStyle"]
+            delete component["textStyle"];
 
     // Conditionals
     if (component.hasOwnProperty("conditional"))
@@ -155,14 +155,14 @@ const removeEmptyDefinitions = (article) => {
           if (util.isString(condition["layout"]))
             if (componentLayouts.hasOwnProperty(condition["layout"]))
               if (Object.keys(componentLayouts[condition["layout"]]).length === 0)
-                delete condition["layout"]
+                delete condition["layout"];
 
         // Component styles - conditional
         if (condition.hasOwnProperty("style"))
           if (util.isString(condition["style"]))
             if (componentStyles.hasOwnProperty(condition["style"]))
               if (Object.keys(componentStyles[condition["style"]]).length === 0)
-                delete condition["style"]
+                delete condition["style"];
 
         // Component text styles - conditional
         if (condition.hasOwnProperty("textStyle"))
@@ -197,7 +197,7 @@ const removeEmptyDefinitions = (article) => {
     if (Object.keys(componentTextStyles[textStyle]).length === 0)
       delete componentTextStyles[textStyle];
   });
-}
+};
 
 
 /**
@@ -283,7 +283,7 @@ const removeUnusedReferences = (article) => {
     if (!textStyles.includes(textStyle))
       delete componentTextStyles[textStyle];
   });
-}
+};
 
 
 /**
@@ -297,7 +297,7 @@ const removeComment = (object) => {
 
   if (object.hasOwnProperty("comment"))
     delete object["comment"];
-}
+};
 
 
 module.exports = {

diff --git a/lib/util.js b/lib/util.js
@@ -1,10 +1,7 @@
 'use strict';
 
 const isString = (property) => {
-  if (typeof property === 'string' || property instanceof String)
-    return true;
-
-  return false;
+  return typeof property === 'string' || property instanceof String;
 };
 
 module.exports = {