Is DetectChanges() needed in NorthwindDbContext?

[matteocontrini]

Hi,
the AuditableEntity implementation is interesting, but I'm wondering if the call to ChangeTracker.DetectChanges(); is really needed.

https://github.com/JasonGT/NorthwindTraders/blob/2c0659e759c41b05719e174caa4836156ce74c9b/Src/Persistence/NorthwindDbContext.cs#L53-L55

According to the official docs, DetectChanges() is called automatically when going through the entries of the ChangeTracker:

DetectChanges() is usually called automatically by the context when up-to-date information is required (before SaveChanges() and when returning change tracking information)

[jasontaylordev]

Hi Matt - thanks for the feedback. You're right - detect changes was not required. In the above commit I've removed it and added some integration tests to verify the behaviour. Thanks! 👍