Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RISC-V support #37

Merged
merged 1 commit into from
May 17, 2023
Merged

Add RISC-V support #37

merged 1 commit into from
May 17, 2023

Conversation

hack3ric
Copy link
Contributor

Add riscv32 and riscv64 syscall enum and invoke support.

The 32-bit one is not currently supported by Rust, but implemented anyway for future riscv32-linux targets.

@jasonwhite
Copy link
Owner

jasonwhite commented May 17, 2023

Awesome! Everything looks perfect except for a couple of things:

  1. Can you add riscv64gc-unknown-linux-gnu to the list of targets in .github/workflows/ci.yml? (Both the stable and nightly sections.)
  2. Add the architecture-specific feature flags to Cargo.toml. Note that you can still add riscv32 there even though it isn't technically supported by Rust. It just means that the syscall table is enabled, not the syscall functions themselves. There are cases where one might want to have access to the syscall table from another architecture.

@hack3ric
Copy link
Contributor Author

Done.

@jasonwhite jasonwhite merged commit 3d79f11 into jasonwhite:main May 17, 2023
18 checks passed
hack3ric added a commit to hack3ric/archriscv-packages that referenced this pull request May 24, 2023
- nix: Add `nix::sys::ptrace::{get,set}regs` for newer platforms that
does not support `PTRACE_{GET,SET}REGS`
(nix-rust/nix#2044)
- syscalls: Add riscv32 and riscv64 syscall support
(jasonwhite/syscalls#37)
- lurk: Add syscalls groups (taken from strace) and parameter lists for
riscv64 (will upstream when nix's PR is merged)
felixonmars pushed a commit to felixonmars/archriscv-packages that referenced this pull request May 25, 2023
- nix: Add `nix::sys::ptrace::{get,set}regs` for newer platforms that
does not support `PTRACE_{GET,SET}REGS`
(nix-rust/nix#2044)
- syscalls: Add riscv32 and riscv64 syscall support
(jasonwhite/syscalls#37)
- lurk: Add syscalls groups (taken from strace) and parameter lists for
riscv64 (will upstream when nix's PR is merged)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants