Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] filter still active after reopen new session #2344

Closed
3 tasks
PeterKlaren opened this issue Oct 16, 2023 · 4 comments · Fixed by jasp-stats/jasp-desktop#5288
Closed
3 tasks

[Bug] filter still active after reopen new session #2344

PeterKlaren opened this issue Oct 16, 2023 · 4 comments · Fixed by jasp-stats/jasp-desktop#5288
Assignees

Comments

@PeterKlaren
Copy link

JASP Version

0.18.1

Commit ID

No response

JASP Module

Unrelated

What analysis are you seeing the problem on?

Filtering data

What OS are you seeing the problem on?

Windows 11

Bug Description

In a csv data set >600 observations from 21 different student teams, I filter out team 18. Then close JASP to do some external editing on the data. Reopening the cleaned and dataset in a fresh JASP instance, the filter still is active, with no way to clear it?!

Expected Behaviour

Filters should have been cleared upon reopening a data set.

Steps to Reproduce

...

Log (if any)

No response

Final Checklist

  • I have included a screenshot showcasing the issue, if possible.
  • I have included a JASP file (zipped) or data file that causes the crash/bug, if applicable.
  • I have accurately described the bug, and steps to reproduce it.
@github-actions
Copy link

@PeterKlaren, thanks for taking the time to create this issue. If possible (and applicable), please upload to the issue website (#2344) a screenshot showcasing the problem, and/or a compressed (zipped) .jasp file or the data file that causes the issue. If you would prefer not to make your data publicly available, you can send your file(s) directly to us, issues@jasp-stats.org

@PeterKlaren
Copy link
Author

The screenshot show file handSpanBodyHeight2023_validated.csv, first imported in JASP, then two filters applied "team != 20" and "sex != N/A". Then closed, then opened again to see that the filters are still active with the filter field empty. Double clicking the dustbin is not effective.

BTW: I attempted this because JASP doesn't display a customizable scatter plot per team when N/A is present?

handSpanBodyHeight2023_validated.csv

image

@shun2wang shun2wang changed the title https://jasp-stats.org/cooperative-vision-and-goals/BBughttps://jasp-stats.org/cooperative-vision-and-goals/Dhttps://jasp-stats.org/2018/03/29/request-feature-report-bug-jasp/A [Bug] filter still active after reopen new session Oct 17, 2023
boutinb added a commit to boutinb/jasp-desktop that referenced this issue Oct 17, 2023
Fixes jasp-stats/jasp-issues#2344

2 issues:
. the labelFilterGenerator keeps a copy of the R constructed filter string: this is unnecessary, it can use directly this string from the Filter object
. the _columnNameUsedInEasyFilter map in DataSetPackage must be cleared when it is reset.
@boutinb
Copy link
Contributor

boutinb commented Oct 17, 2023

Hi @PeterKlaren This will be fixed in the next release. The only workarounds I see now is either to start a new JASP session, or to set a dummy filter.

@JorisGoosen
Copy link
Contributor

@PeterKlaren maybe give the N/A ones a label NA?

JorisGoosen pushed a commit to jasp-stats/jasp-desktop that referenced this issue Oct 18, 2023
Fixes jasp-stats/jasp-issues#2344

2 issues:
. the labelFilterGenerator keeps a copy of the R constructed filter string: this is unnecessary, it can use directly this string from the Filter object
. the _columnNameUsedInEasyFilter map in DataSetPackage must be cleared when it is reset.
shun2wang pushed a commit to shun2wang/jasp-desktop that referenced this issue Oct 23, 2023
Fixes jasp-stats/jasp-issues#2344

2 issues:
. the labelFilterGenerator keeps a copy of the R constructed filter string: this is unnecessary, it can use directly this string from the Filter object
. the _columnNameUsedInEasyFilter map in DataSetPackage must be cleared when it is reset.
shun2wang pushed a commit to shun2wang/jasp-desktop that referenced this issue Oct 23, 2023
Fixes jasp-stats/jasp-issues#2344

2 issues:
. the labelFilterGenerator keeps a copy of the R constructed filter string: this is unnecessary, it can use directly this string from the Filter object
. the _columnNameUsedInEasyFilter map in DataSetPackage must be cleared when it is reset.
JorisGoosen pushed a commit to jasp-stats/jasp-desktop that referenced this issue Jan 2, 2024
Fixes jasp-stats/jasp-issues#2344

2 issues:
. the labelFilterGenerator keeps a copy of the R constructed filter string: this is unnecessary, it can use directly this string from the Filter object
. the _columnNameUsedInEasyFilter map in DataSetPackage must be cleared when it is reset.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants