-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] filter still active after reopen new session #2344
Comments
@PeterKlaren, thanks for taking the time to create this issue. If possible (and applicable), please upload to the issue website (#2344) a screenshot showcasing the problem, and/or a compressed (zipped) .jasp file or the data file that causes the issue. If you would prefer not to make your data publicly available, you can send your file(s) directly to us, issues@jasp-stats.org |
The screenshot show file handSpanBodyHeight2023_validated.csv, first imported in JASP, then two filters applied "team != 20" and "sex != N/A". Then closed, then opened again to see that the filters are still active with the filter field empty. Double clicking the dustbin is not effective. BTW: I attempted this because JASP doesn't display a customizable scatter plot per team when N/A is present? |
Fixes jasp-stats/jasp-issues#2344 2 issues: . the labelFilterGenerator keeps a copy of the R constructed filter string: this is unnecessary, it can use directly this string from the Filter object . the _columnNameUsedInEasyFilter map in DataSetPackage must be cleared when it is reset.
Hi @PeterKlaren This will be fixed in the next release. The only workarounds I see now is either to start a new JASP session, or to set a dummy filter. |
@PeterKlaren maybe give the N/A ones a label NA? |
Fixes jasp-stats/jasp-issues#2344 2 issues: . the labelFilterGenerator keeps a copy of the R constructed filter string: this is unnecessary, it can use directly this string from the Filter object . the _columnNameUsedInEasyFilter map in DataSetPackage must be cleared when it is reset.
Fixes jasp-stats/jasp-issues#2344 2 issues: . the labelFilterGenerator keeps a copy of the R constructed filter string: this is unnecessary, it can use directly this string from the Filter object . the _columnNameUsedInEasyFilter map in DataSetPackage must be cleared when it is reset.
Fixes jasp-stats/jasp-issues#2344 2 issues: . the labelFilterGenerator keeps a copy of the R constructed filter string: this is unnecessary, it can use directly this string from the Filter object . the _columnNameUsedInEasyFilter map in DataSetPackage must be cleared when it is reset.
Fixes jasp-stats/jasp-issues#2344 2 issues: . the labelFilterGenerator keeps a copy of the R constructed filter string: this is unnecessary, it can use directly this string from the Filter object . the _columnNameUsedInEasyFilter map in DataSetPackage must be cleared when it is reset.
JASP Version
0.18.1
Commit ID
No response
JASP Module
Unrelated
What analysis are you seeing the problem on?
Filtering data
What OS are you seeing the problem on?
Windows 11
Bug Description
In a csv data set >600 observations from 21 different student teams, I filter out team 18. Then close JASP to do some external editing on the data. Reopening the cleaned and dataset in a fresh JASP instance, the filter still is active, with no way to clear it?!
Expected Behaviour
Filters should have been cleared upon reopening a data set.
Steps to Reproduce
...
Log (if any)
No response
Final Checklist
The text was updated successfully, but these errors were encountered: