Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: .jasp file does not open / load after downloading 0.18.2 #2517

Closed
3 tasks done
LindaHoffmann opened this issue Jan 7, 2024 · 6 comments · Fixed by jasp-stats/jasp-desktop#5377
Closed
3 tasks done

Comments

@LindaHoffmann
Copy link

JASP Version

0.18.2

Commit ID

No response

JASP Module

Unrelated

What analysis are you seeing the problem on?

No response

What OS are you seeing the problem on?

Windows 11

Bug Description

I cannot open my .jasp file after downloading the newest version of the tool. When trying to open it in jasp 0.18.2.0, the loading page pops up and closes immediately.

Could you please help me to understand how this can be fixed? I have attached the respective .jasp file for you as a zip file.
Thanks for your help!
data_environmentalbehaviour__v8.zip

Expected Behaviour

file should have opened

Steps to Reproduce

...

Log (if any)

No response

Final Checklist

  • I have included a screenshot showcasing the issue, if possible.
  • I have included a JASP file (zipped) or data file that causes the crash/bug, if applicable.
  • I have accurately described the bug, and steps to reproduce it.
@RensDofferhoff
Copy link

RensDofferhoff commented Jan 7, 2024

Thanks for your report!
Do you remember the version with which you created this file?

@LindaHoffmann
Copy link
Author

LindaHoffmann commented Jan 8, 2024 via email

@RensDofferhoff
Copy link

RensDofferhoff commented Jan 8, 2024

Very interesting bug!
Do you remember how you generated the "Umweltverhalten gesamt DT" column?
This is the source of the fault.
Its seems you generated it using the computed column feature but the 'formula' is gone and no information on how to generate it is stored anymore.

I tweaked the JASP file by hand so it is no longer a computed column. Now it opens again. Please check that it is in order:
data_environmentalbehaviour__v8_fixed.zip

Of course there is an underlying issue that caused this file to generate this way. We need to resolve this so any information on the history of this file is helpful!

@RensDofferhoff
Copy link

RensDofferhoff commented Jan 8, 2024

@JorisGoosen what do you make of the internal db state?
Perhaps we should just make columns codetypes revert to normal columns and throw a warning instead letting the error propagate.

@JorisGoosen JorisGoosen changed the title [Bug]: .jasp file does not open / load after downloading newest version of the tool [Bug]: .jasp file does not open / load after downloading 0.18.2 Jan 8, 2024
boutinb added a commit to boutinb/jasp-desktop that referenced this issue Jan 8, 2024
The computedColumnType 'unknown' does not exist anymore, but might be stored in the database. So we need to take care of this
Fixes jasp-stats/jasp-issues#2517
boutinb added a commit to boutinb/jasp-desktop that referenced this issue Jan 8, 2024
The computedColumnType 'unknown' does not exist anymore, but might be stored in the database. So we need to take care of this.
Fixes jasp-stats/jasp-issues#2517
@boutinb
Copy link
Contributor

boutinb commented Jan 8, 2024

We will make a new version soon (hopefully this week) that fixes this issue.

@JorisGoosen JorisGoosen reopened this Jan 8, 2024
@LindaHoffmann
Copy link
Author

LindaHoffmann commented Jan 8, 2024 via email

JorisGoosen added a commit to jasp-stats/jasp-desktop that referenced this issue Jan 9, 2024
* Unknown computed column type

The computedColumnType 'unknown' does not exist anymore, but might be stored in the database. So we need to take care of this.
Fixes jasp-stats/jasp-issues#2517

* Use try-catch instead

* Remove the isColumn property

the _isColumn property of Column class can be deduced by the codeType property, so remove it from the class.
However for downgrade purpose, the isColumn column in the database is kept so that JASP file made in 0.18.3 can be still read in 0.18.2 or 0.18.1.

* mention isComputed in update function for later removal

---------

Co-authored-by: Joris Goosen <joris@jorisgoosen.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants