Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use geom_rangeframe and themeJaspRaw #52

Merged
merged 3 commits into from Oct 7, 2021
Merged

Use geom_rangeframe and themeJaspRaw #52

merged 3 commits into from Oct 7, 2021

Conversation

koenderks
Copy link
Contributor

Closes #51

@koenderks koenderks requested review from vandenman and removed request for vandenman October 3, 2021 17:18
@Kucharssim Kucharssim self-requested a review October 7, 2021 10:27
Kucharssim
Kucharssim requested changes Oct 7, 2021
View reviewed changes
Copy link
Member

@Kucharssim Kucharssim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me... I left a couple of minor comments, I am not sure if you need/want to act on them. If not, just mark them as resolved and re-request the review.

R/bainCommon.R Outdated Show resolved Hide resolved
R/bainCommon.R Outdated Show resolved Hide resolved
R/bainCommon.R Outdated Show resolved Hide resolved
R/bainCommon.R Show resolved Hide resolved
Kucharssim
Kucharssim approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@Kucharssim Kucharssim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good now; I think the plots improved as well.

If this is something that can/needs to be included in the release, it can be merged.

@koenderks koenderks merged commit 66a0e60 into jasp-stats:master Oct 7, 2021
@koenderks koenderks deleted the jaspGraphs-update branch October 7, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kucharssim Kucharssim Kucharssim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use geom_rangeframe and themeJaspRaw for plots
2 participants
@koenderks @Kucharssim