Add scores to data #215
Merged
Add scores to data #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliuspfadt
force-pushed
the
addScoresToData
branch
from
3e9f6f8
to
0edbee4
Compare
FBartos
requested changes
May 28, 2024
R/exploratoryfactoranalysis.R
Outdated
| colNameR <- colNamesR[ii] | ||
|
|
||
| if (jaspBase:::columnExists(colNameR) && !jaspBase:::columnIsMine(colNameR)) { | ||
| .quitAnalysis(gettext("Column name already exists in the dataset")) |
There was a problem hiding this comment.
I think it would make sense to also say which variable name already exists (otherwise it might be a bit confusing for users with very wide datasets)
juliuspfadt
force-pushed
the
addScoresToData
branch
from
0edbee4
to
1498ce8
Compare
FBartos
approved these changes
May 29, 2024
|
seems like your review does not count... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes jasp-stats/jasp-issues#101