New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extentions to JAGS #83
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, so much functionality! Looks really good :)
I left just a couple of remarks for option names, otherwise the code looks really good.
@Kucharssim I've removed the name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! there were two radio buttons with the name |
Fixes https://github.com/jasp-stats/INTERNAL-jasp/issues/2132
Fixes https://github.com/jasp-stats/INTERNAL-jasp/issues/2133
Fixes https://github.com/jasp-stats/INTERNAL-jasp/issues/2134
Here an example file I for testing, rename and drop .zip:
exampleNewJagsFunctionality_nostate.jasp.zip
Also, I'm aware I haven't made any unit tests. They are on my list but I figured I wanted to open the PR before the deadline!
All the comments that start with
TODO for inference
will be finished for the next release and won't be part of this PR.