Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effect size and CIs independent of test point #24

Merged
merged 2 commits into from Dec 2, 2020

Conversation

AlexanderLyNL
Copy link
Contributor

- Same as stable: jasp-stats/jasp-desktop#4407
- Removed namespace and dot in front of `VovkSellkeMPR`
@AlexanderLyNL
Copy link
Contributor Author

AlexanderLyNL commented Nov 24, 2020

When playing around with the developer module

  • DESCRIPTION
  • Namespace

were edited, I removed them from this PR. Do I have to include them?

@vandenman
Copy link
Contributor

Only actual changes in the NAMESPACE file are worth committing. Changes to the description you can ignore for now.

R/ttestonesample.R Outdated Show resolved Hide resolved
@AlexanderLyNL
Copy link
Contributor Author

Don can you tell me how to trigger the unit test?

@AlexanderLyNL
Copy link
Contributor Author

@vandenman There seems to be a problem with setting up jaspTools for the unit test:

Error in .setupJaspTools(pathJaspDesktop, pathJaspRequiredPkgs, installJaspModules, :
jaspTools setup could not be completed. Reason: could not fetch the jasp-stats/jasp-desktop repo and as a result the required dependencies are not installed.

If this problem persists clone jasp-stats/jasp-desktop manually and provide the path to setupJaspTools() in pathJaspDesktop.

Is there something I need to do?

@vandenman
Copy link
Contributor

Is there something I need to do?

No, for some reason the clone of jasp-desktop fails (see Slack). I'll see if I can fix this today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants