Your data is accessible in excel file and a readme document in Turkish has been added #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasperan
requested changes
Apr 18, 2023
There was a problem hiding this comment.
Please, remove from your local (or empty) the following pull request, or add them to your .gitignore so they are not included in the PR:
- database/database.db
- chromedriver.exe
Also, remove .pyc files from the commit so we don't include compiled code that won't serve to other users!
database folder and xlxs file added
|
I added database folder and excel file and deleted the pyc folder from there. |
jasperan
requested changes
Apr 18, 2023
|
Okay I deleted chromedriver.exe . Anything else because I'm junior python developer :) |
|
congrats @BerkeGokturk71 this is a good Pull Request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can See your data in Excel format and Turkish language support added.Chrome driver updated for new chrome versions.
"-e" parameter create your excel file.Now Readme File support Turkish language.I added samples.Finally I did some code reviews.