Update tts.py for Bing TTS support #421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal to is to replace Google TTS and be able to support many different languages.
bing-tts:
client_id: CLIENT-ID
client_secret: CLIENT-SECRET
bing_options: MaxQuality|female
language: zh-chs
The goal to is to replace Google TTS and be able to support many different languages. bing-tts: client_id: CLIENT-ID client_secret: CLIENT-SECRET bing_options: MaxQuality|female language: zh-chs
Fixing whitespace for flake testing
| class BingTTS(AbstractMp3TTSEngine): | ||
| """ | ||
| Uses the Bing TTS online translator | ||
| Appropiated from: https://github.com/wilfilho/BingTranslator |
There was a problem hiding this comment.
That's a problem. That code is licensed under GPL, while Jasper is MIT. So we can't incorporate that code without @wilfilho's permission. What we can do is use the API of that module (which is probably a good idea in any case).
Holzhaus
added a commit
that referenced
this pull request
Jan 11, 2016
Replaces PR #421 which can't be merged due to an incompatible license.
|
Because of the licensing issue I was unable to merge this. However, the desired functionality has been added in commit c9514b0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal to is to replace Google TTS and be able to support many different languages.
bing-tts:
client_id: CLIENT-ID
client_secret: CLIENT-SECRET
bing_options: MaxQuality|female
language: zh-chs