Added automatic testing and publishing through Github Actions #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaspersiebring
changed the title
Mypy fixes (wherever reasonable)
This reverts commit 364e06c.
…artial key matching)
…sh only on pushes to protected main)
…or manually releasing on TestPyPi.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently includes three Github Actions workflows: (1) quality control check for pull requests (pytest, mypy and pylint), (2) publish to PYPI on merged pull requests and (3) a manual build for development purposes. Also features caching since wxPython takes forever to build (>45m) and doesn't have readily-available wheels for Linux distros on PYPI (see https://wxpython.org/pages/downloads/).
The way we currently cache ensures that small versions bumps or new independent packages don't require entirely new
poetry installcalls (which dramatically speeds up workflow runs from >45 minutes to ~1 minute). This does have some caveats that we just have to watch out for (e.g. cache bloat/stale dependencies, see actions/setup-python#627).Edit: Also, all workflows currently run on Github's default runners (ubuntu-latest) so currently only Linux artifacts.
Edit 2: Did an interactive rebase to cut down on some of the redundant commits (e.g. build triggers and tests).