modify Text.Digestive.Forms.Happstack to use [Input] instead of Input #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… This is needed to support multiple select. It also makes it easier to support checkboxes.
jaspervdj
added a commit
that referenced
this pull request
May 2, 2011
modify Text.Digestive.Forms.Happstack to use [Input] instead of Input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I noticed in git that you changed FormInput to have getInputStrings and getInputTexts. I am not sure why you did this, but I highly approve. In order to support ..., I need to be able to get back multiple results that all have the same key name (eg, foo=1&foo=3).
This is now possible with the getInputStrings function. However in order to exploit that, the Happstack module needs to work with [Input] instead of Input.
So that is what this patch does.
This breaks compatibility with the old digestive-functors-happstack, so according to the package version policy I should bump the version from 0.0.2.1 to 0.1.0.0. But you don't seem to be following the policy so I will leave the version numbering up to you.
http://www.haskell.org/haskellwiki/Package_versioning_policy
It would great to have a new release on hackage..