Change makePendingConnection to accept a Stream instead of a Socket

[nilscc]

Hi!

I'd like to propose the following change: Use a Stream argument for makePendingConnection instead of a Socket. This allows the use of more general streams, e.g. for a TLS connection. Currently, this is the easiest and cleanest solution since it is not possible to implement something like makePendingConnection outside of the websockets library because of the decodeRequestHead function, which is a private function from the hidden module Network.Websockets.HTTP.

This change does break the current API, but I think it is a reasonable change and easy to fix for any users of this function (see e.g. the change in runApp).

– McManiaC

[jaspervdj]

I get the idea, but I don't like breaking backward compatibility when it is easily avoidable. What you could do here is have two functions:

makePendingConnection :: Socket -> ConnectionOptions -> IO PendingConnection
makePendingConnectionFromStream :: Steam.Stream -> ConnectionOptions -> IO PendingConnection

Then the implementation of the first one is very straightforward: call makeSocketStream and then call makePendingConnectionFromStream.

This ensures user convenience & backward compatibility. :-)

[nilscc]

Fair enough, I added another function and reverted the type of makePendingConnection.

[jaspervdj]

Thanks!