Refactor tests related to Person Gender and created tests for remaini…

…ng one

Signed-off-by: Jonathan Schweder <jonathanschweder@gmail.com>

person.go

@@ -100,8 +100,6 @@ var (
 		"Zboncak", "Zemlak", "Ziemann", "Zieme", "Zulauf"}
 
 	suffix = []string{"Jr.", "Sr.", "I", "II", "III", "IV", "V", "MD", "DDS", "PhD", "DVM"}
-
-	gender = []string{"Male", "Female"}
 )
 
 // Person is a faker struct for Person
@@ -217,7 +215,7 @@ func (p Person) NameFemale() string {
 
 // Gender returns a fake Gender for Person
 func (p Person) Gender() string {
-	return p.Faker.RandomStringElement(gender)
+	return p.Faker.RandomStringElement([]string{p.GenderMale(), p.GenderFemale()})
 }
 
 // NameAndGender returns a fake NameAndGender for Person

person_test.go

@@ -53,15 +53,13 @@ func TestLastName(t *testing.T) {
 func TestName(t *testing.T) {
 	p := New().Person()
 	name := p.Name()
-	gender := p.Gender()
 	Expect(t, true, len(name) > 0)
 	Expect(t, false, strings.Contains(name, "{{titleMale}}"))
 	Expect(t, false, strings.Contains(name, "{{firstNameMale}}"))
 	Expect(t, false, strings.Contains(name, "{{titleFemale}}"))
 	Expect(t, false, strings.Contains(name, "{{firstNameFemale}}"))
 	Expect(t, false, strings.Contains(name, "{{lastName}}"))
 	Expect(t, false, strings.Contains(name, "{{suffix}}"))
-	Expect(t, true, gender == "Male" || gender == "Female")
 }
 
 func TestGender(t *testing.T) {
@@ -70,6 +68,16 @@ func TestGender(t *testing.T) {
 	Expect(t, true, gender == "Male" || gender == "Female")
 }
 
+func TestGenderMale(t *testing.T) {
+	p := New().Person()
+	Expect(t, "Male", p.GenderMale())
+}
+
+func TestGenderFemale(t *testing.T) {
+	p := New().Person()
+	Expect(t, "Female", p.GenderFemale())
+}
+
 func TestNameAndGender(t *testing.T) {
 	p := New().Person()
 	name, gender := p.NameAndGender()