Add implementation of binary string generator for Faker #72
Conversation
|
@bhatipradeep congrats for the first contribution, can you just describe what is the use case of this generator? |
|
Thanks @jaswdr . The most common usecase for students is to design testcases of various competitive programming problems. |
|
right, please check the Codacy report, there are some violations. |
binarystring.go
Outdated
| } | ||
|
|
||
| //BinaryNumberOfLength returns random binary string with given input length | ||
| func (bn BinaryString) BinaryStringOfLength(l int) string { |
There was a problem hiding this comment.
Minor change, please use BinaryString.
There was a problem hiding this comment.
change function name ?
binarystring_test.go
Outdated
| ) | ||
|
|
||
| //check if given string is binary or not | ||
| func CheckIfBinaryString(binary_string string) bool { |
There was a problem hiding this comment.
Since this function is only used in the TestBinaryStringOfLength and no other test should use it, can you move this code to the TestBinaryStringOfLength?
There was a problem hiding this comment.
Yes. It can be shifted to test itself for now.
|
@jaswdr updated code with changes. |
|
@bhatipradeep released in v1.6.0, congrats for your first merge 🎉 |
Description
Added a binary string generator for faker.
Are you trying to fix an existing issue?
No
Go Version
Go Tests