Adding Blood type generator #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add fake Blood instance for Faker
jaswdr
requested changes
Jul 25, 2022
There was a problem hiding this comment.
Hey @kharmaodo, thank you very much for the code, I reviewed it and commented, can you address them?
|
Changed |
kharmaodo
commented
Jul 25, 2022
jaswdr
approved these changes
Jul 25, 2022
|
LGTM, merged, congratulations for your first PR 🎉 |
|
Released in v1.13.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding Blood type generator.
Are you trying to fix an existing issue?
Replace this line with a link to the issue you are trying to fix
Go Version
Go Tests