Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Swap double-quotes in first and last names with single-quotes #152

Merged
merged 1 commit into from
Sep 26, 2023
Merged

[BUG] Swap double-quotes in first and last names with single-quotes #152

merged 1 commit into from
Sep 26, 2023

Conversation

mwgrimm
Copy link
Contributor

@mwgrimm mwgrimm commented Sep 25, 2023

Description

Replaces double-quotes in generated person first and last names with single-quotes.

Are you trying to fix an existing issue?

#151

Go Version

$ go version
go version go1.21.1 darwin/amd64

Go Tests

$ go test
2023/09/25 16:58:13 Error while requesting https://loremflickr.com/300/200 : request failed
2023/09/25 16:58:13 Error while creating a temp file: temp file creation failed
2023/09/25 16:58:13 Error while requesting https://randomuser.me : request failed
2023/09/25 16:58:13 Error while creating a temp file: temp file creation failed
PASS
ok      github.com/jaswdr/faker 4.592s

@jaswdr jaswdr merged commit 802c3f2 into jaswdr:master Sep 26, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants