Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhance more beautiful valid text alerts by using modal #28

Merged
merged 2 commits into from
Oct 3, 2021

Conversation

Armakuji
Copy link
Contributor

@Armakuji Armakuji commented Oct 3, 2021

Related Issue or bug

Fixes: #26

Describe the changes you've made

  • add valid text modal
  • add some css

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Original Updated
Screen Shot 2021-10-03 at 3 29 15 PM Screen Shot 2021-10-03 at 3 29 50 PM

@netlify
Copy link

netlify bot commented Oct 3, 2021

✔️ Deploy Preview for bookslibraryreactjs ready!

🔨 Explore the source changes: 6566312

🔍 Inspect the deploy log: https://app.netlify.com/sites/bookslibraryreactjs/deploys/6159a9afd540b70008f1d42a

😎 Browse the preview: https://deploy-preview-28--bookslibraryreactjs.netlify.app/

@jatiinyadav
Copy link
Owner

  1. When someone hovers on the cross, the cursor should be a pointer.
  2. Do the styling changes in the style.scss file not in style.css.
  3. Resolve the conflicts.

@Armakuji
Copy link
Contributor Author

Armakuji commented Oct 3, 2021

OK, Thanks for your review. I will fix that.

@Armakuji
Copy link
Contributor Author

Armakuji commented Oct 3, 2021

@jatiinyadav I fixed all the comments ✨. Please review again.

@jatiinyadav jatiinyadav added hacktoberfest Hacktoberfest hacktoberfest-accepted Hacktoberfest-Accepted labels Oct 3, 2021
@jatiinyadav
Copy link
Owner

@Armakuji Thank you for your contribution. Looking forward to more such amazing contributions 🥂

@jatiinyadav jatiinyadav merged commit dce268d into jatiinyadav:master Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Hacktoberfest hacktoberfest-accepted Hacktoberfest-Accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Enhance more beautiful valid text alerts by using modal
2 participants