Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Landing Page Responsive #15

Closed
jatiinyadav opened this issue May 8, 2024 · 9 comments
Closed

[FIX] Landing Page Responsive #15

jatiinyadav opened this issue May 8, 2024 · 9 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers gssoc An issue for GSSOC'24 level1 GSSOC Level 1

Comments

@jatiinyadav
Copy link
Owner

image

  • Make the landing page responsive for all the screen sizes.
  • Make sure to do the styling changes in styles/common.css
@jatiinyadav jatiinyadav added enhancement New feature or request good first issue Good for newcomers gssoc An issue for GSSOC'24 labels May 8, 2024
@IP80808080
Copy link

👋 Hello! I'd be happy to help with this issue. Could you please assign it to me? Additionally, could you please label it for the appropriate level? Thank you! 🚀

@jatiinyadav jatiinyadav added the level1 GSSOC Level 1 label May 10, 2024
@IP80808080
Copy link

IP80808080 commented May 12, 2024

Hello Sir
I have submitted a pull request for issue #15, which includes a video explanation for better understanding. I kindly request you to review the pull request.
Sir, I've encountered an issue while reviewing the output of my changes. After making adjustments and checking for responsiveness, I've noticed that the changes aren't immediately reflected. Is this a problem with my browser or IDE? Interestingly, upon reloading the page, the responsiveness updates are visible.

@jatiinyadav
Copy link
Owner Author

Hello Sir I have submitted a pull request for issue #15, which includes a video explanation for better understanding. I kindly request you to review the pull request. Sir, I've encountered an issue while reviewing the output of my changes. After making adjustments and checking for responsiveness, I've noticed that the changes aren't immediately reflected. Is this a problem with my browser or IDE? Interestingly, upon reloading the page, the responsiveness updates are visible.

Hi,
I am unable to view the video which you are taking about.

@IP80808080
Copy link

Oh sorry my bad, I have made the boiler answer for the future submission of Issues, and I forget to make change in this one

@jatiinyadav
Copy link
Owner Author

@IP80808080 Can you please add the video, so that I can review the PR.

@jatiinyadav
Copy link
Owner Author

@IP80808080 Any updates?

@IP80808080
Copy link

I will share the latest update today itself, my exams were going on, that's why it took me a while

@IP80808080
Copy link

Sir I have Removed the previous pull request since there was some changes required, and submitted a pull request for issue #15, which includes a video explanation for better understanding. I kindly request you to review the pull request

Responsive.mp4

Copy link

This issue has been automatically closed because it has been inactive for more than 30 days. If you believe this is still relevant, feel free to reopen it or create a new one. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers gssoc An issue for GSSOC'24 level1 GSSOC Level 1
Projects
None yet
Development

No branches or pull requests

2 participants